search

tildearrow / furnace

a multi-system chiptune tracker compatible with DefleMask modules
GNU General Public License v2.0
2.65k stars 209 forks source link

Automatically change OPN instrument to OPM instrument and vice versa on the fly so preview and load works without manually fixing each instrument. #807

Closed Soulchip closed 1 year ago

Soulchip commented 1 year ago

I cannot test or hear any of my FM instruments, they are all displayed in red in the file selector and when I load them they do no sound.

I'm using YM2151, on YM2612 they do work fine and I can preview them... aren't they the same? I can preview both on deflemask using any of both chips.

Acoustic Bass.zip

freq-mod commented 1 year ago

It loads via drag and drop, the instrument you uploaded is of OPN type.

Furnace some time ago, has split OPM and OPN instrument types. In older versions of Furnace and Deflecrap, it was the same. It seems 4-op FM deflemask instruments are loaded as OPN files, and because of that, it won't work on OPM.

Most likely intended. To "fix" - click on "type" drop-down menu under the instrument name in -||- editor and select "FM OPM". It will convert to OPM and work.

Soulchip commented 1 year ago

Hmmm that makes sense, I see now that a few values change if I just load the instrument and reselect "opm" when I open an opn instrument... I understand the difference now but can we make it so that when you try to load or "test" an opn instrument into an opm chip the instrument is played and when you load it automatically transforms it into opm?...

I tried now with different instruments and they sound almost the same... I don't see why we can't have this in furnace too... I mean, I don't want to load 20.835 instruments on Furnace and resave them again just befcause I change from ym2612 to 2151...

Can't Furnace automatically take my opn instrument and convert it to opm on the fly so i can preview it and load it without having to reselect opm type?

Soulchip commented 1 year ago

I changed the title because this is not actually a bug but it is a nice feature to have.

freq-mod commented 1 year ago

Yeah, an option to set .dmp FM loading instruments to OPM type rather than OPN would be welcome

tildearrow commented 1 year ago

Now what if you have both OPM and OPN in the song?

Soulchip commented 1 year ago

i see what you mean, what if you have both ym2151 and ym2612 on the same song... then I guess you make the convertion if you load your instrument while standing on the other chip. You can reverse it back with the type option but in any case...your instrument will always get played, that0s a plus for me.

Soulchip commented 1 year ago

At least let us preview the instrument before it is loaded, then we can "fix it" manually ourselves...maybe you can just let the file loader preview the instrument regardless of the selected chip? I don't know... anything is better than "no preview" or having to duplicate our big instrument collection and convert it.

Crimson-foxGITHUB commented 1 year ago

This is a feature DefleMask Legacy already has built-in for switching between YM2151 and YM2612 instruments, so it'd be nice to see.