search

tildearrow / furnace

a multi-system chiptune tracker compatible with DefleMask modules
GNU General Public License v2.0
2.62k stars 207 forks source link

Sample and wavetable editors don't show up after double-clicking a sample and/or wavetable while they're docked with the pattern editor #817

Closed Curly68 closed 1 year ago

Curly68 commented 1 year ago

Sorry for the verbose title of the issue, i just don't know how to explain it in a shorter way. It seems that the sample and wavetable editors windows don't appear in front of you when you double click the samples and/or wavetables you want to edit if those editors are docked with the pattern editor. Meanwhile the instrument editor appears and behaves just fine like it should even when docked with the pattern editor. That behavior does not happen with the sample and wavetable editors when you make them separate windows again btw

https://user-images.githubusercontent.com/104454752/210161628-c4806f67-c06b-4f92-871f-9df227680e79.mp4

https://user-images.githubusercontent.com/104454752/210161635-5199e050-c4c8-4dea-8fbd-4fef6a95c587.mp4

tildearrow commented 1 year ago

It's supposed to work though?

extern/imgui_patched/imgui.cpp:7429

Curly68 commented 1 year ago

Same bug still happens even on the latest DEV build of Furnace. As you can see I'm trying to right-click one of the samples to open the sample editor, but it just does not appear.

https://user-images.githubusercontent.com/104454752/213698256-91ba0264-34f5-4e64-9252-47ab2cf1ec9e.mp4

tildearrow commented 1 year ago

Fixed!!! It was that we weren't actually focusing upon double-clicking...