search

tildearrow / kwin-lowlatency

archived - X11 full-screen unredirection and lots'a settings for KWin
373 stars 10 forks source link

kwin-lowlatency and nvidia 435.17 - performance regression? #36

Closed torvic9 closed 5 years ago

torvic9 commented 5 years ago

It seems that kwin-lowlatency doesn't work well together with the latest nvidia driver. Performance (scrolling, moving windows, hovering menus, etc.) is noticeably worse than before with driver 430.40. Going back to either default kwin or to the previous driver solves this. What I haven't tried yet is to recompile kwin-lowlatency, although I'm not sure whether and how that would change anything.

(Manjaro, kwin 5.16.4, kernel 4.19, GTX 1070)

tildearrow commented 5 years ago

Sorry, I was sick yesterday and could not attend your bug report in time.

Please comment out all instances of "glFinish();", and try again. I want to see if it has to do with that call.

torvic9 commented 5 years ago

No problem, I hope your health is fine again.

Please note that I'm not a coder and I don't speak C++. I grepped for the glFinish string and found 3 instances of it, which I then commented out, created a patchfile, inserted it into the PKGBUILD, and recompiled.

Not 100% sure, but I don't think it made a difference.

Here's the patchfile so that you can check whether I did this correctly: https://gist.github.com/torvic9/f4e486af6010133b205c3d0c6a17c3d6

tildearrow commented 5 years ago

Can you try commenting the "waitSync" part in plugins/platforms/x11/standalone/glxbackend.cpp at line 765?

torvic9 commented 5 years ago

On top of the previous "glFinish" changes? Wouldn't that mean to change the entire "if" clause?

tildearrow commented 5 years ago

No, separate.

tildearrow commented 5 years ago

Also, can you try with 435.21?

tildearrow commented 5 years ago

I must hurry! Daniel in the other side, already fixed this issue in GNOME (and he even gets a chance in mainline).

So please give me 2 hours to sleep, 1 to eat, 1 to go to bathroom, 1 to eat, 1 to dress/get ready, 2 for an event I must attend, 1 for going back home, 0.5 to eat, 0.5 to plug in the NVIDIA card back (yeah removed it because it was causing my AMD card to shut off) and finally get this fixed before tomorrow otherwise 5.16.5 will be a crappy release and nobody will want it.

So at 8-9pm I will be ready to begin looking at this and probably add a "VSync control" option in case you're in a working version

tildearrow commented 5 years ago

Please try with latest git version. I have pushed a fix.

torvic9 commented 5 years ago

Sorry for not responding earlier, didn't have time... I'm now on 435.21 as well and will report back later today.

EDIT: yes, I think you did it :-) Performance is now good again, as it seems, even slightly better than default kwin. You can close this issue I guess.

tildearrow commented 5 years ago

Great. Thanks for the feedback!

realnc commented 4 years ago

I noticed 5.18.2 enabled this hack. I'm on 5.18.1 right now with nvidia driver 440.59, vsync mechanism set to automatic and I'm not seeing any issues. To get the current behavior after the upgrade, I assume I need to choose the "none and hope for the best" setting?

tildearrow commented 4 years ago

@realnc Yep, exactly. See issue #42 as well