tildearrow / kwin-lowlatency

archived - X11 full-screen unredirection and lots'a settings for KWin
373 stars 10 forks source link

Patch doesn't apply against kwin 5.18.4.1 #71

Closed realnc closed 4 years ago

realnc commented 4 years ago

https://download.kde.org/stable/plasma/5.18.4/kwin-5.18.4.1.tar.xz

CMakeLists.txt fails and seems to contain the patch (or part of it?) already.

tildearrow commented 4 years ago

Oh wow, I didn't realize they would make a .1 release...

Please try again with v5.18.4-3 that I just released a bit ago. If it still fails, please provide reject files.

agates commented 4 years ago

This is working against 5.18.4.1 in the Gentoo overlay.

realnc commented 4 years ago

It still doesn't apply for me. I do:

./patch.sh

to generate the patch. However, this downloads and creates a patch against kwin-5.18.4.tar.xz, not kwin-5.18.4.1.tar.xz. Try to apply that fails with:

patching file CMakeLists.txt
Reversed (or previously applied) patch detected!  Assume -R? [n]

The reject file is:

$ cat CMakeLists.txt.rej
--- CMakeLists.txt      2020-03-31 14:33:01.000000000 +0300
+++ CMakeLists.txt      2020-04-01 14:35:10.568088719 +0300
@@ -1,7 +1,7 @@
 cmake_minimum_required(VERSION 3.1 FATAL_ERROR)

 project(KWIN)
-set(PROJECT_VERSION "5.18.3")
+set(PROJECT_VERSION "5.18.4")
 set(PROJECT_VERSION_MAJOR 5)

 set(QT_MIN_VERSION "5.12.0")
tildearrow commented 4 years ago

sighs It appears you downloaded the source tar from releases. I did some changes to the patch maker. Ugh, let me release again...

realnc commented 4 years ago

sighs It appears you downloaded the source tar from releases.

No, I use this git repo.

tildearrow commented 4 years ago

Tr-

tildearrow commented 4 years ago

I just released 5.18.4-4 with the updated patch maker.

Ugh why KWin team...

realnc commented 4 years ago

Yep, works fine now.

tildearrow commented 4 years ago

Good to hear.