search

tildeio / MessageChannel.js

27 stars 3 forks source link

Fixed issue with messages missing event field in FF #21

Closed msgerbush closed 4 years ago

msgerbush commented 9 years ago

Looks like in the latest Firefox MessageChannel is still being supplanted by this library, however because MessagePort is implemented frames without MessageChannel.js are pushing valid MessageEvents. As a result decodeEvent is receiving a legitimate MessageEvent that does not need to be faked. For these events, just pass them on as-is to avoid an ‘event is undefined’ error in the decoding.

msgerbush commented 9 years ago

Looks like tests are failing due to an old bower version. Let me know if you'd like me to update that as well.

cyril-sf commented 9 years ago

Not sure if it's a bower version issue, but it probably doesn't hurt to update it.

That would be great if you could do it in this PR but in a separate commit!

msgerbush commented 9 years ago

Looks like there's some issue with Sauce Connect now, but I thought that was shut off for PR builds...any ideas?

wagenet commented 4 years ago

Closing due to staleness.