Closed knownasilya closed 2 years ago
@wagenet could you approve the actions to run?
could you approve the actions to run?
@knownasilya done! 🙂
@simonihmig again? :)
@simonihmig another, when you have time ofc 😄
@knownasilya done! Still pretty red-ish 😏
@simonihmig sigh, again.
@knownasilya could you rebase this with main?
@josemarluedke rebased. Btw, feel free to submit prs to this if you have time today.
@knownasilya you might want to rebase this PR, thing might be looking better now.
@knownasilya can you rebase this PR again?
I think this PR is pretty good at this point.
I believe we have a failing test in ember-classic, but I'm not sure how to approach that one.
Could someone let CI run?
cc/ @cibernox @SergeAstapov
@simonihmig I applied your suggestion (good thinking) just need the run approved
@simonihmig looks like this is ready to go
LGTM but maybe someone else wants to take a look at the code
@cibernox Can you merge this and cut a release? Looking forward to have the new dependencies released.
I just merged this. Also, it seems I am able to publish, given this is automated in CI. Just added proper PR labels (also for older PRs), and will try to run release-it
with a minor bump due to breaking changes here...
Includes breaking changes