tildeio / ember-element-helper

Dynamic element helper for Glimmer templates.
MIT License
44 stars 23 forks source link

Update to Ember 4 and Octane blueprint, drop support for Ember < 3.24 #73

Closed knownasilya closed 2 years ago

knownasilya commented 2 years ago

Includes breaking changes

knownasilya commented 2 years ago

@wagenet could you approve the actions to run?

simonihmig commented 2 years ago

could you approve the actions to run?

@knownasilya done! 🙂

knownasilya commented 2 years ago

@simonihmig again? :)

knownasilya commented 2 years ago

@simonihmig another, when you have time ofc 😄

simonihmig commented 2 years ago

@knownasilya done! Still pretty red-ish 😏

knownasilya commented 2 years ago

@simonihmig sigh, again.

josemarluedke commented 2 years ago

@knownasilya could you rebase this with main?

knownasilya commented 2 years ago

@josemarluedke rebased. Btw, feel free to submit prs to this if you have time today.

cibernox commented 2 years ago

@knownasilya you might want to rebase this PR, thing might be looking better now.

josemarluedke commented 2 years ago

@knownasilya can you rebase this PR again?

josemarluedke commented 2 years ago

I think this PR is pretty good at this point.

I believe we have a failing test in ember-classic, but I'm not sure how to approach that one.

Could someone let CI run?

cc/ @cibernox @SergeAstapov

knownasilya commented 2 years ago

@simonihmig I applied your suggestion (good thinking) just need the run approved

knownasilya commented 2 years ago

@simonihmig looks like this is ready to go

cibernox commented 2 years ago

LGTM but maybe someone else wants to take a look at the code

josemarluedke commented 2 years ago

@cibernox Can you merge this and cut a release? Looking forward to have the new dependencies released.

simonihmig commented 2 years ago

I just merged this. Also, it seems I am able to publish, given this is automated in CI. Just added proper PR labels (also for older PRs), and will try to run release-it with a minor bump due to breaking changes here...

simonihmig commented 2 years ago

https://github.com/tildeio/ember-element-helper/releases/tag/v0.6.0 :tada: