search

tildeio / ember-element-helper

Dynamic element helper for Glimmer templates.
MIT License
44 stars 23 forks source link

Allow Embroider v1 deps; Drop node v10 #74

Closed josemarluedke closed 2 years ago

josemarluedke commented 2 years ago

Node 10 is not compatible with embroider v1.

josemarluedke commented 2 years ago

Pushed a commit adding ember-source as peer dep because newer embroider macros's dependencySatisfies needs it to work reliable. See https://github.com/embroider-build/embroider/pull/1070

Tests should pass now.

josemarluedke commented 2 years ago

Failing tests are due to Ember v4 requiring ember-auto-import v2. Which can be solved in other PR.

cibernox commented 2 years ago

Since that is a different issue I'm going to merge this as is

cibernox commented 2 years ago

thanks!

cibernox commented 2 years ago

@josemarluedke to clarify, are you upgrading ember-auto-import next?

josemarluedke commented 2 years ago

@cibernox PR coming.

jamescdavis commented 2 years ago

Can we get a release with this? 🙂

josemarluedke commented 2 years ago

I think we can merge #73 and then release it. Looking forward to have a release out as well.

lifeart commented 2 years ago

adding more search keywords here, updating to 0.6.0 from 0.5.5 fixes 

Build Error (broccoli-persistent-filter:Babel > [Babel: @embroider/macros]) in @embroider/macros/runtime.js

C:\Users\lifeart\Documents\repos\smassetman_spa\smassetman\@embroider\macros\runtime.js: @babel/template placeholder "OPTIONS": Expected string substitution

error for me, as I understand, it's related to @embroider/util version