search

tildeio / ember-element-helper

Dynamic element helper for Glimmer templates.
MIT License
44 stars 23 forks source link

In what ember-source version do I no longer need this addon? #86

Closed NullVoxPopuli closed 1 year ago

NullVoxPopuli commented 1 year ago

I forget if this has been implemented yet

chancancode commented 1 year ago

From the README

This addon provides a polyfill high fidelity reference implementation of RFC #389, including the proposed amendments in RFC PR #620.

Please note that while RFC #389 has been approved, it has not been implemented in Ember.js yet. As such, the feature is still subject to change based on implementation feedback.

When this feature is implemented in Ember.js, we will release a 1.0 version of this addon as a true polyfill for the feature, allowing the feature to be used on older Ember.js versions and be completely inert on newer versions where the official implementation is available.

I believe this is still current.

NullVoxPopuli commented 1 year ago

how do we implement the element helper? would that be a glimmer-vm thing?

chancancode commented 1 year ago

Yeah. I think so. We will probably have to invent some new concepts in the glimmer-vm internals to thread this through. I suppose we can also try to reuse the existing code that handles the classic ember components since apparently that works almost perfectly fine.