[Bugfix] fix props first logic

tildeio / htmlbars

A variant of Handlebars that emits DOM and allows you to write helpers that manipulate live DOM nodes

MIT License

1.61k stars 193 forks source link

Closed stefanpenner closed 9 years ago

stefanpenner commented 9 years ago

for exceptions input.form, input.list, button.type always use setAttributes
for form.action always escape
always assign handlers to props, even if the case appears strange
refactor normalizeProperty to return an object that clearly indicates type: & normalized:

stefanpenner commented 9 years ago

cc @jayphelps @mixonic

stefanpenner commented 9 years ago

~~hmm missing a test, 1 sec~~ nm its present.

mixonic commented 9 years ago

LGTM. Thanks for the effort on this tricky bit @stefanpenner!

mixonic commented 9 years ago

(Should be [BUGFIX release])

stefanpenner commented 9 years ago

@wycats wanted to sync on this this afternoon.

stefanpenner commented 9 years ago

@mixonic updated

stefanpenner commented 9 years ago

@rwjblue

@wycats wanted to sync on this this afternoon.

stefanpenner commented 9 years ago

oh well, #yolo :shipit: