search

tildeio / htmlbars

A variant of Handlebars that emits DOM and allows you to write helpers that manipulate live DOM nodes
MIT License
1.61k stars 193 forks source link

Use the global URL in node context if in sandbox #439

Closed ronco closed 8 years ago

ronco commented 8 years ago

This is for fastboot sandboxing. URL is provided as a global to the sandbox, and we'll use that rather than trying to require('url').

ronco commented 8 years ago

@tomdale reworked without assigning to the global URL. I think there's still value in having the module.require === "function" protection before falling through to use module.require().

tomdale commented 8 years ago

@ronco Awesome, thank you! The SL test failed so I restarted. As soon as that passes I will merge this and cut a new release.

ronco commented 8 years ago

Weird, looks like the IE9 SL test failed again.