search

tildeio / htmlbars

A variant of Handlebars that emits DOM and allows you to write helpers that manipulate live DOM nodes
MIT License
1.61k stars 193 forks source link

Ensure statement nodes are the same length. #469

Closed rwjblue closed 8 years ago

rwjblue commented 8 years ago

Fixes #468.

mixonic commented 8 years ago

review plz @krisselden?

krisselden commented 8 years ago

@mixonic it looks good, @rwjblue had said he wanted to test it, I gave him some instructions to do this.

This does look like it would address the issue in #468

rwjblue commented 8 years ago

Using https://github.com/ef4/initial-render-perf/pull/4.

Before:

before trace-deopt.sh output

ir hydra output

After:

after trace-deopt.hs output

ir hyrdra output

rwjblue commented 8 years ago

I was being trolled by caching in the After: screenshots above.

@krisselden worked with me to confirm this is now properly avoiding a deopt.

screenshot