Fix crashing with Babel polyfill / Chrome <= v37.0

tildeio / router.js

MIT License

1.35k stars 159 forks source link

Fix crashing with Babel polyfill / Chrome <= v37.0 #292

Closed raido closed 4 years ago

raido commented 4 years ago

Closes: https://github.com/tildeio/router.js/issues/291

It seems with Babel polyfill included Object.isFrozen vs Object.isExtensible has different meaning:

This change was tested on:

IE 10
Chrome v27+
Chrome latest
IE 9 (has some other non related failure)

See screenshots below:

IE 9:

IE 10:

Chrome v27

raido commented 4 years ago

Travis failed because transitive package seems to have dropped Node 6 support.

raido commented 4 years ago

I switched Travis from Node 6 -> 8.

We should drop Node <= 6 and release v7 of this package, after releasing v6.2.6 with this PR and backporting all the way to Ember.js v3.12 LTS over here - https://github.com/emberjs/ember.js/blob/master/package.json#L140

Since Ember.js side uses caret for router_js version ,then simply yarn upgrade router_js would be enough but I am happy to open PR and explicitly set version to v6.2.6.

And then for Ember canary include v7 of this package.

raido commented 4 years ago

Any updates on this?

raido commented 4 years ago

@rwjblue ping :)

rwjblue commented 4 years ago

Thank you @raido!