search

tildeio / router.js

MIT License
1.35k stars 159 forks source link

fix: qp-only transition during initial transition #307

Open buschtoens opened 4 years ago

buschtoens commented 4 years ago

Seems to fix https://github.com/emberjs/ember.js/issues/18577.

image

jelhan commented 4 years ago

Please see my comment here: https://github.com/emberjs/ember.js/issues/18577#issuecomment-719001736 Not sure if this is another bug or if this fix does not address the root cause.

rwjblue commented 4 years ago

This fix looks good conceptually, but we need to fixup the tests and add a specific test for the scenario described in https://github.com/emberjs/ember.js/issues/18577

wagenet commented 2 years ago

@buschtoens status?

Mikek2252 commented 1 year ago

@buschtoens @rwjblue Is this solution still good? if so is there anything i can do to help get this merged? Happy to write the test for it if i can be pushed in the correct general direction, im not overly familiar with this code.