tilemill-project / millstone

middleware for map styles and datasources
BSD 3-Clause "New" or "Revised" License
32 stars 37 forks source link

raster symlinking broken? #100

Open springmeyer opened 11 years ago

springmeyer commented 11 years ago

had a report from @hrwgc that raster data was copied into the project/layers folder instead of being symlinked. Smells like a regression in millstone. Need to dig into this to see if I can replicate.

hrwgc commented 11 years ago

I noticed this behavior on a dev build with raster colorizer. The layers were copied (8GB worth!).

Sent from my iPhone

On May 16, 2013, at 9:51 PM, Dane Springmeyer notifications@github.com wrote:

had a report from @hrwgc that raster data was copied into the project/layers folder instead of being symlinked. Smells like a regression in millstone. Need to dig into this to see if I can replicate.

— Reply to this email directly or view it on GitHub.

springmeyer commented 11 years ago

unable to replicate. If the file path to a .tif is relative then the path to the exact spot is made absolute. If the path is absolute, it is symlinked. I cannot see a case where the data is copied.

hrwgc commented 11 years ago

@springmeyer I'm noticing this behavior again, I'm on TileMill Version 0.10.1 (v0.10.1-59-g338d40a). The source Tiffs are copied to the project/$project/layers/ directory rather than being sym-linked. If you want to try to replicate, here is the tilemill project and source layers.

springmeyer commented 11 years ago

Can you set up a fresh project that also hits this problem, document the steps you took, then share that exactly. A project that already has the data copied in is unlikely to be possible for me to replicate with.

hrwgc commented 11 years ago

Ok - get ready for some odd behavior @springmeyer.

I was able to replicate this issue using TileMill Version 0.10.1 (v0.10.1-120-g182c947).

I had a suspicion the issue was related to Dropbox, as I noticed Dropbox was churning trying to sync while I was working with the tiffs in TileMill. Here's how I replicated the issue.

If Dropbox is running in background (i.e., syncing is not paused) when I create the new project and add the layer to the project, the geotiff is not symlinked to the layers directory, it is copied.

If Dropbox sync is paused when I add the layer to the project, the geotiff is symlinked, not copied.

In both instances during my test to replicate this issue, I only added the geotiff to a clean, new project. I didn't modify carto or any project settings. They use the default PNG24 image setting.

springmeyer commented 11 years ago

bizarre, but thanks for the details.