Invalid mustache tags break tooltips

tilemill-project / tilemill

TileMill is a modern map design studio

https://tilemill-project.github.io/tilemill/

BSD 3-Clause "New" or "Revised" License

3.11k stars 527 forks source link

Invalid mustache tags break tooltips #1008

Open willwhite opened 12 years ago

willwhite commented 12 years ago

If you use a mustache tag for a field that doesn't exist, the entire tooltip breaks. From #997.

yhahn commented 12 years ago

Looked at this briefly. Brain dump:

Very expensive to catch this at project validation or grid render time. It basically means loading the datasource in question separately and finding out what are valid fields.
Stopgap might be to catch this in the tooltip authoring/editing UI which already loads the datasource to know what tokens are available. Maybe it can warn or block you if you try to use a token that doesn't exist. Won't catch cases where a datasource changes underneath a project's feet.

willwhite commented 12 years ago

Yeah the idea of validation during editing sounds the most reasonable and will prevent many of the problems people hit.

mroswell commented 12 years ago

Any progress on validating during editing? (I've got some incredibly detailed tooltips, and would've saved some time today if a validator had been present.)

mroswell commented 12 years ago

It occurs to me that implementing a couple of standard practices would be helpful. The outcome would be slightly different than validating, but would still yield quicker access to functional tooltips. Here are my suggestions:

Enlarge the default area for the list of fields. (I have a lot of fields, and the 3-line limit is a bit frustrating.)
Make both the template area, and list of fields resizable. This can be signalled with a ribbed triangle in the lower right (for instance this edit area on github uses that resizing system.)
Enable insertion of the field into the template area by double-clicking on the field name.