tilemill-project / tilemill

TileMill is a modern map design studio
https://tilemill-project.github.io/tilemill/
BSD 3-Clause "New" or "Revised" License
3.12k stars 528 forks source link

pkg-config protobuf --version needs to be pkg-config protobuf --nodversion #2715

Open dreirund opened 5 years ago

dreirund commented 5 years ago

Describe the bug ./configure.js spills out

[...]
[tilemill configure] Could not configure TileMill because "pkg-config protobuf --version" returned an error (pkgconf: --version specified with other options or module names, assuming --modversion.)

This does come from a run of pkg-config protobuf --version:

pkgconf: --version specified with other options or module names, assuming --modversion.
3.7.0

Instead, pkg-config protobuf --modversion should be executed:

3.7.0

Environment: (Note: We are not setup to test on Linux or Windows so help may be slower on those OSs)

To Reproduce

Expected behavior ./configure.js finishes without error messages.

dreirund commented 5 years ago

Patch attached.

AND: Please configure your issue tracker to support .patch and .diff-files as well. You make it unneededly complicated for users to hand in patches ... (who does not use git but uses the "classic" ways ...)

configure-js.protobuf.fix-versionargument.patch.txt