search

tilemill-project / tilemill

TileMill is a modern map design studio
https://tilemill-project.github.io/tilemill/
BSD 3-Clause "New" or "Revised" License
3.12k stars 528 forks source link

force amd64 in docker-compose to support m1 cpu #2758

Closed fatelgit closed 2 years ago

fatelgit commented 2 years ago

in order to start the docker stack on an apple m1 cpu device it is necessary to set the platform attribute - otherwise the build will fail with this error: Failed to execute '/usr/local/bin/node /usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js configure --fallback-to-build --module=/usr/src/app/node_modules/mapnik/lib/binding/mapnik.node --module_name=mapnik --module_path=/usr/src/app/node_modules/mapnik/lib/binding' (1)

csytsma commented 2 years ago

@apbarratt @Stoiker @xycarto @SaidAlSouti Any of you guys able to test this PR before merging?

Stoiker commented 2 years ago

I will take a look at it

Stoiker commented 2 years ago

Okay it seems to work on my Fedora system. Looking at https://stackoverflow.com/a/57298610 it should also be possible to multiply the platform tag to support other systems (Windows anyone?) but I am not familiar with those. Maybe the rest has an opinion on that.

For me a merge would be fine.

P.S. The noted issue with v2/v3 docker-compose in the StackOverflow answer seems to be gone (?) https://docs.docker.com/compose/compose-file/