search

tilemill-project / tilemill

TileMill is a modern map design studio
https://tilemill-project.github.io/tilemill/
BSD 3-Clause "New" or "Revised" License
3.11k stars 527 forks source link

icon missing for new OS X app on 10.6 #843

Closed springmeyer closed 12 years ago

springmeyer commented 12 years ago

TileMill.app upgraded from 0.5 to 0.6.0 is not affected (has an icon) but a freshly downloaded 0.6.0 build does not:

willwhite commented 12 years ago

Is the icon still missing after a restart? What if you change to the icon view? I can't replicate this.

springmeyer commented 12 years ago

yes, starting or stopping the app make no difference. This is with a fresh 0.6.0 downloaded into the download folder (and not moved). Looking at it in the icon view shows:

springmeyer commented 12 years ago

closing, re-starting finder fixed this so must be a fluke on my system.

incanus commented 12 years ago

@springmeyer, when you are seeing this, can you check in the app bundle itself? In Contents/Resources, there should be a valid application.icns, and Contents/Info.plist should reference it.

I doubt these would get corrupted, so my hunch is it is something to do with the unzipping process when it happens manually, i.e., in the Finder, vs. by Sparkle, which does it atomically behind the scenes.

It might be related to us using -9 as an argument to zip in the Makefile and unzipping takes a bit longer, Finder thinks things are done before they are, and the bundle isn't seen right in its eyes.

@springmeyer, does running touch on the bundle help?

springmeyer commented 12 years ago

I can't replicate anymore after re-launching the finder but I will return to this if I see it again.