tilezen / go-tilepacks

A Go-based tile downloader that saves to deduplicated mbtiles files.
MIT License
14 stars 3 forks source link

Update to use Go modules #7

Closed thisisaaronland closed 5 years ago

thisisaaronland commented 5 years ago

Personally I have no feelings about package/dependency managers beyond "If Go is going to settle this for everyone, as with go fmt then I am okay with it".

Go modules depend on things having v{X}.{Y}.{Z} semantic tags/releases so this package should probably start minting releases too, in the interest of playing nice with others.

nvkelso commented 5 years ago

@zerebubuth can you have a look at this PR since Ian is away?

iandees commented 5 years ago

I started this using dep, which I thought was the preferred way of doing dependencies with Go nowadays.

zerebubuth commented 5 years ago

Yeah, I thought that dep was the current / future preferred way too. But looking at their README:

dep was the "official experiment." The Go toolchain, as of 1.11, has adopted an approach that sharply diverges from dep.

So... I guess that means that this week the official preferred way is go mod? What do you think, @iandees?

iandees commented 5 years ago

Sounds good to me. Guess I should read more about go modules then :)

zerebubuth commented 5 years ago

Great, thanks!