search

tilezen / joerd

Joerd can be used to download, merge and generate tiles from digital elevation data
MIT License
319 stars 49 forks source link

Add Mapzen API key to terrain collect script #127

Closed nvkelso closed 7 years ago

nvkelso commented 7 years ago

Fixes #128.

nvkelso commented 7 years ago

Fixed @migurski review in https://github.com/tilezen/joerd/pull/127/commits/ba86ad71913cc0b33a38fe783269d8ff3538281f, now passes on CircleCI.

I've required the Mapzen API key in https://github.com/tilezen/joerd/pull/127/commits/67706891e28ddc4fcb9deddae73a63e8d31f0227, but keeping it an argument instead of positional (as a user I get confused when there lots of positional).

Should be ready to go?

nvkelso commented 7 years ago

@migurski you good with the changes?

migurski commented 7 years ago

Looks okay to me! I guess that sending a request with ?api_key= on the end will behave as though the key were simply missing?

nvkelso commented 7 years ago

I think it will trigger key validity logic (versus anonymous IP address throttling), but that is an api_axle implementation detail?

On Jan 31, 2017, at 19:15, migurski notifications@github.com wrote:

Looks okay to me! I guess that sending a request with ?api_key= on the end will behave as though the key were simply missing?

― You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.