search

tilezen / joerd

Joerd can be used to download, merge and generate tiles from digital elevation data
MIT License
324 stars 50 forks source link

Split NED into topology and topobathy parts #15

Closed zerebubuth closed 8 years ago

zerebubuth commented 8 years ago

This should help to alleviate the overlapping nature of the files doesn't cause too many problems.

Connects to #3.

@rmarianski could you review, please?

rmarianski commented 8 years ago

Looks good! :+1:

I personally try to avoid inheritance and base classes everywhere I can. If there's anything that needs to vary behavior-wise, I usually just pass references to functions around to handle that. I do recognize that this is somewhat a stylistic preference though :)

zerebubuth commented 8 years ago

Good point! I refactored in ac522da to use composition rather than inheritance. The code is a little bit longer, but might be easier to maintain / test. Could you take another look, please, and let me know what you think?

rmarianski commented 8 years ago

:+1: