Closed benoit9126 closed 1 year ago
@benoit9126 I'm not the repo owner or maintainer but IMO you should split this PR in multiple small PR and first discuss change in issue (e.g usage of poetry), it might ease the reviewer and increase the likelihood of the fix to be merged :-)
Ok. Do you have a priority order among the points listed above?
Ok. Do you have a priority order among the points listed above?
my 2c is dropping python2 support and protobuf generation are higher priority.
@rmarianski : The next possible steps would be:
protobuf
Python code to solve #113 Poetry
with a pyproject.toml
I start to implement the first which is the most important for me. If the community aggrees with the two other proposals, I can provide them too.
round
function of Python 2 and 3 that forces you to use quantize
and to pass a round function in some operators (encode
for instance). As now, only Python 3 is supported, we could remove this argument round_fn
and just use the round function.@rmarianski I close this PR as everything was added in other PR.
Hi,
Here is a large proposal to update this Python package. It contains
protobuf
Python code to solve #113 ~ #119Poetry
with apyproject.toml
pre-commit
(black
,isort
,flake8
, etc)~ #121tox
for the tests.~ #116