search

tilezen / mapbox-vector-tile

Python package for encoding & decoding Mapbox Vector Tiles
MIT License
240 stars 47 forks source link

Update type -> geom_type #124

Closed rmarianski closed 1 year ago

rmarianski commented 1 year ago

The shapely type property is deprecated. This updates our usage to use the geom_type property instead.

https://github.com/shapely/shapely/issues/975

coveralls commented 1 year ago

Coverage Status

Coverage: 77.341% (-0.7%) from 78.038% when pulling c24f645091226d9fa638519cf5aa711f0ba20e6a on geom_type into 5249a23da696515f118564dbcc83b39216792454 on master.

benoit9126 commented 1 year ago

Great!

I think that the SimpleShape class can also be fully deleted and the shapely shape function used instead. See here.

rmarianski commented 1 year ago

I think that the SimpleShape class can also be fully deleted and the shapely shape function used instead. See here.

good call :bow: Removed it in 46a118d