tilezen / mapbox-vector-tile

Python package for encoding & decoding Mapbox Vector Tiles
MIT License
240 stars 47 forks source link

Following V2 Specification #125

Closed benoit9126 closed 1 year ago

benoit9126 commented 1 year ago

Implement the remaining part of #42.

@rmarianski The current version of the package solves my problem of protobuf dependencies (with or without this PR). I just had some time. I don't see what else I could add for now. Maybe #107. When do you plan to make a release (including #124) ?

coveralls commented 1 year ago

Coverage Status

Coverage: ?%. Remained the same when pulling 0921618510d42c6f272b05e92d96d643b6f45852 on benoit9126:v2-spec into 5249a23da696515f118564dbcc83b39216792454 on tilezen:master.

coveralls commented 1 year ago

Coverage Status

Coverage: 78.292% (+0.3%) from 78.038% when pulling 0921618510d42c6f272b05e92d96d643b6f45852 on benoit9126:v2-spec into 5249a23da696515f118564dbcc83b39216792454 on tilezen:master.

benoit9126 commented 1 year ago

Yes, there is this "lineTo" command which must have movements. I am not sure, but I think that thanks to the lines 70-71 here, if there are no coordinates after the "lineTo", nothing is added in the tile. I don't know if it is sufficient to ensure the request of the comment of #42.

pr's always appreciated :)

:rocket:

For #107, there are interesting details in OGR documentation: here.