Encode version 1 in layers

tilezen / mapbox-vector-tile

Python package for encoding & decoding Mapbox Vector Tiles

MIT License

241 stars 47 forks source link

Encode version 1 in layers #47

Closed rmarianski closed 8 years ago

rmarianski commented 8 years ago

Connects to https://github.com/mapzen/mapbox-vector-tile/issues/42

@zerebubuth could you review please?

coveralls commented 8 years ago

Coverage remained the same at 93.131% when pulling 53ab7079139d0e4ee89e9ee922927a87309c5e93 on encode-version-1 into 773dbfdc38e75ab08f572f6a1c5fc321007dc252 on master.

rmarianski commented 8 years ago

Thinking about this a little bit more, could it have consequences in tangram wrt the multipolygon winding order changes?

zerebubuth commented 8 years ago

As far as I can tell from Tangram's decoder, it isn't checking the version, so I think we're safe to "downgrade" to v1 for the moment.

zerebubuth commented 8 years ago

:+1:

rmarianski commented 8 years ago

Cool. I forgot that tangram itself was handling decoding multipolygons.