Optional OSM-only places layer

tilezen / vector-datasource

Tilezen vector tile service - OpenStreetMap data in several formats

https://www.nextzen.org/

Other

507 stars 119 forks source link

Optional OSM-only places layer #1418

Open matkoniecz opened 6 years ago

matkoniecz commented 6 years ago

What did you see? two labels for Kleparz
What did you expect to see? one label
What map location are you having problems with? City and country are helpful, as well as tile coordinates or latitude / longitude.

https://mapzen.com/tangram/play/?#17.50000/50.07097/19.94142

Screenshot? Props for animated gifs.

selection_004

with https://github.com/ENT8R/streetcomplete-mapstyle/blob/283c61b29f27cc6f018d84ba364662be6d9ea12d/style.yaml style (reporting here as whosonfirst.mapzen.com may be correct in this case)

zerebubuth commented 6 years ago

Looks like the label on the left comes from WOF as a neighbourhood, and the label on the right comes from OSM as a locality. We removed OSM neighbourhoods in #359 and followed up with boroughs, suburbs and quarters in #744, because of duplicates similar to these. However, we still include localities and various other place types from OSM.

Might it be worth including both sets of data, perhaps in separate layers, to allow style designers to choose which data set works best? I haven't checked, but my assumption is that these "high zoom" place types don't contribute a huge amount to tile size.

matkoniecz commented 6 years ago

Might it be worth including both sets of data

For what is it worth I would happily use that. In my case I prefer OSM data as at least in my region it is of higher quality and as an OSM mapper even wrong OSM data is also welcomed - I just edit and fix it. The same applies for other internal OSM styles, like ongoing style for StreetComplete.

nvkelso commented 6 years ago

Putting on my project manager hat here: The default places layer shouldn't have duplicate features in it, but for practical reasons it does today and will for a little bit longer. As @zerebubuth points out the duplicate here is because we're sourcing categorically (by kind) between OSM and Who's On First and the categorization is not the same. I'm open to including an optional OSM-only places layer, but that's unlikely to be the default places because of other Mapzen projects and priorities. Retitling this issue to capture that idea (as otherwise it's a dup of your earlier issue).

nvkelso commented 5 years ago

Related to https://github.com/tilezen/vector-datasource/issues/383, which deals with mixed Natural Earth and OpenStreetMap data for places layer locality features.