tilezen / vector-datasource

Tilezen vector tile service - OpenStreetMap data in several formats
https://www.nextzen.org/
Other
505 stars 119 forks source link

Add beverages to pois layer #1647

Open nvkelso opened 5 years ago

zerebubuth commented 5 years ago

Related: #448, https://github.com/tilezen/vector-datasource/pull/1468#discussion_r198444646

Is it worth merging alcohol, wine and beverages under the same kind, and use kind_detail for the (perhaps very fine) distinction between these?

nvkelso commented 5 years ago

Interesting, that's what some of the comments in the OSM wiki also suggest.

The appealing thing about using beverages is it's non-alchoholic focus. Could be soft drinks (soda), even boba tea!

The way I've seen it in the USA is most alcohol shops also sell some wine but it's not the focus, while wine shops almost only sell wine and maybe a top shelf of spirits. So I'm okay having 3 kinds here in Tilezen... and maybe we do a little more work on shop=beverage to detect which types of beverage and if it's alcohol or wine then force it to be one of those instead. They'd certainly get different icon artwork.

nvkelso commented 4 years ago

See related definitions in https://github.com/tilezen/vector-datasource/issues/1939 and https://gist.github.com/stepps00/afec2769f9227d6dc1cfb418974aa20b.