search

tilezen / vector-datasource

Tilezen vector tile service - OpenStreetMap data in several formats
https://www.nextzen.org/
Other
507 stars 119 forks source link

Add ferry lines to roads layer #187

Closed nvkelso closed 8 years ago

nvkelso commented 9 years ago

Routes that go from land to water to land again show gaps in the map today for the ferry part, let's fill those in.

Read up: https://wiki.openstreetmap.org/wiki/Tag:route%3Dferry

Sounds like it has the same general structure as roads with the highway tag but are route=ferry for the primary distinction.

Let's brainstorm how we want these kinds to end up in tiles (we don't want them to default render as roads).

zerebubuth commented 9 years ago

Perhaps these should end up in the transit layer, rather than the roads layer? They'd end up with kind=ferry by default, it looks like.

nvkelso commented 9 years ago

We pack railway in the roads layer now and a good number of ferries are more part of the road network than the public transit network, so we already have the "not road things drawing sometimes as roads" in a default styling problem. I'd rather keep the transit layer for things that are specifically public transit.

Reading up on the wiki, it looks like ferry=* should be included (at least for a minimum set of popular values, like we currently do for roads), and with the high-road logic extended to set kind=ferry.

Default OSM styling shows these coming in very early (8 or 9 I remember)? Should we do that or throttle it based on the ferry=* value (like we do for roads)?

zerebubuth commented 9 years ago

After mapzen/TileStache#64 and #281, it looks like this:

Zoom 9

187-sf-z9

Zoom 10

187-sf-z10

Zoom 11

187-sf-z11

zerebubuth commented 9 years ago

@nvkelso could you review, please?

nvkelso commented 9 years ago

I dig it :)

Considerations:

  1. I mentioned in the PR but we probably need a way to show select ferries at zoom 8 (when OSM data starts coming in) as there are ferries from Natural Earth rendered that would otherwise hide at 8, then show again at
  2. See further discussion there.
  3. San Francisco has a decent amount of ferries, but New York has way more. And Athens (and Greece in general) have even more. The length buckets should be tested in those places too.

On Thu, Oct 1, 2015 at 2:54 PM, Matt Amos notifications@github.com wrote:

@nvkelso https://github.com/nvkelso could you review, please?

— Reply to this email directly or view it on GitHub https://github.com/mapzen/vector-datasource/issues/187#issuecomment-144860804 .

zerebubuth commented 9 years ago
  1. Yup, updated the PR to pull in ferries at zoom 8, and generally show more to correspond to what NE is pulling in.

Zoom 8

187-sf-z8

Zoom 9

187-sf-z9-2

Zoom 10

187-sf-z10-2

  1. Yup, we should push this to dev so that we can test for the whole world.
nvkelso commented 9 years ago

@rmarianski Was this taken to dev? I'm not seeing ferry lines in SF or NYC tiles, for instance NYC:

rmarianski commented 9 years ago

I took master, but it looks like this pr hasn't been merged yet: https://github.com/mapzen/vector-datasource/pull/281

nvkelso commented 9 years ago

I've merged this one now (the TileStache change was already merged).

nvkelso commented 9 years ago

I see these in NYC and SF now, thanks!