search

tilezen / vector-datasource

Tilezen vector tile service - OpenStreetMap data in several formats
https://www.nextzen.org/
Other
509 stars 120 forks source link

fix linter on master #2036

Closed peitili closed 2 years ago

peitili commented 2 years ago

There are some linter violations that might be brought by

https://github.com/tilezen/vector-datasource/pull/2001 https://github.com/tilezen/vector-datasource/pull/2015

so fixing those

iandees commented 2 years ago

FWIW, I had pre-commit enabled/installed when I was working on this code and it didn't catch any of these.

peitili commented 2 years ago

FWIW, I had pre-commit enabled/installed when I was working on this code and it didn't catch any of these.

that's because your PR branch didn't rebase some of the newer linters I believe? so I suggested something like I mentioned in here

https://github.com/tilezen/vector-datasource/issues/2021#issuecomment-992996482