tilezen / vector-datasource

Tilezen vector tile service - OpenStreetMap data in several formats
https://www.nextzen.org/
Other
502 stars 118 forks source link

Add winter sports related POIs #344

Closed nvkelso closed 8 years ago

nvkelso commented 8 years ago

Pairing with https://github.com/mapzen/vector-datasource/issues/342 and https://github.com/mapzen/vector-datasource/issues/343, we should add a few more POIs for winter sports.

Any others seem interesting? Add them to the list :)

zerebubuth commented 8 years ago

sport=bobsled doesn't appear to be in the database at all (taginfo), but there are 8 instances of sport=luge, so we can use that instead. The sled rental tags only have a single use apiece, which makes me think they're not well-used. However, there are 1,603 uses of man_made=snow_cannon and 1,485 for man_made=snow_fence.

We're going to have the same problem for rental keys as we had for #423 - since that key isn't in osm2pgsql.style we aren't guaranteed to get all of them in the database. We should get most, though, as rental shops probably have names.

nvkelso commented 8 years ago

Luge instead of Bobsled sounds fine. Let's skip the sled rental. Good catch on the snow cannon and snow fence!

File related issue for the rental keys?

zerebubuth commented 8 years ago

Screenshots for a couple of winter sports POI types:

Ski shop in Big Bear:

Scene file snippet:

                ski-rental-or-shop:
                  filter:
                    any:
                      - kind: [ski, ski_rental]
                      - { kind: sports, sport: skiing }
                  draw: { icons: { sprite: marijuana-dispensary } }

big-bear-z18-after

Ski jumping "racetracks" in Lake Placid

Scene file snippet:

        racetrack:
          filter: { kind: racetrack }
          draw:
            lines:
              interactive: true
              order: 5
              cap: round
              join: round
              color: '#cc3333'
              width: [[13,3px],[15, 4px], [16, 5px], [18, 10m], [19, 15m]]

lake-placid-z17-after

zerebubuth commented 8 years ago

File related issue for the rental keys?

Good point, filed #433 so that we don't lose this issue.

nvkelso commented 8 years ago

NOTE: migration still needs to be sorted out for some rental tags.

nvkelso commented 8 years ago

Fixed up the sports_centre landuse AOI color, too, so it's not green on green in this area (can see the entire ski training area polygon now, the pitches, and the runs).

nvkelso commented 8 years ago

I've verified a good many of these, going to assume the rest of them are working. If something needs tuning, we'll follow up in the next release.

nvkelso commented 8 years ago

@sensescape you could really go wild with new icons here!

'ski' 'ski_rental' 'ski_school' 'snow_cannon' 'athletics', 'running', 'horse_racing', 'bmx', 'disc_golf', 'cycling', 'ski_jumping', 'motor', 'karting', 'obstacle_course', 'equestrian', 'alpine_slide', 'soap_box_derby', 'mud_truck_racing', 'skiing', 'drag_racing', 'archery'

sensescape commented 8 years ago

oooooh!