tilezen / vector-datasource

Tilezen vector tile service - OpenStreetMap data in several formats
https://www.nextzen.org/
Other
505 stars 118 forks source link

WOF neighbourhoods should export localized names #418

Closed nvkelso closed 8 years ago

nvkelso commented 8 years ago

https://whosonfirst.mapzen.com/spelunker/id/85910293/

This neighbourhood has a default name in Japanese, which is what we're exporting as the name in tiles. But there are other languages, and we should export those, too.

nvkelso commented 8 years ago

/cc @thisisaaronland

nvkelso commented 8 years ago

Moving out of the v0.7 milestone to load balance.

There's also some changes in the works on the WOF side for default name and localized names that might require additional work, so would like to batch with that.

Plus Tangram still doesn't have ability to auto-switch displayed languages, so...

nvkelso commented 8 years ago

And again to v0.9

thisisaaronland commented 8 years ago

See also: https://github.com/whosonfirst/whosonfirst-data/issues/183

rmarianski commented 8 years ago

@zerebubuth what do you think of making a new hstore column in the database to store all of these? That way, we can include it as the tags value in the query, and it should just get included in the output via the usual transform. We'd have to make sure that we used the same i18n scheme as osm when we save the data, or maybe it makes more sense to have the transform be more flexible to support both schemes.

zerebubuth commented 8 years ago

Hstore sounds good.

If we start translating between schemes, then it makes it more work for us later on. Reading the WOF name docs I'm confused as it keeps referring to country codes, and we use ISO 639-1 language codes...

I feel it might be easier to just expose the data that WOF has and let whoever's making the map choose what's the appropriate country / language codes for them.

nvkelso commented 8 years ago

We need should resolve this inconsistency for customers on the server as part of this issue.

On May 12, 2016, at 03:22, Matt Amos notifications@github.com wrote:

Hstore sounds good.

If we start translating between schemes, then it makes it more work for us later on. Reading the [WOF name docs] I'm confused as it keeps referring to country codes, and we use ISO 639-1 language codes...

I feel it might be easier to just expose the data that WOF has and let whoever's making the map choose what's the appropriate country / language codes for them.

― You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub

rmarianski commented 8 years ago

@dianashk we'd like to be consistent with what you end up doing in search. What do you think?

thisisaaronland commented 8 years ago

That the WOF documentation refers to country codes is a bug. The docs mean to indicate that we are using ISO-639-3 language codes. See also:

https://www.w3.org/International/articles/language-tags/#language

I will update the docs, shortly, when I am not using my hands to put food in my mouth...

rmarianski commented 8 years ago

Just spoke with @dianashk and @orangejulius, and we'll update to use iso-693-3 codes across the board. We'll normalize the tags from osm to convert the iso-693-1 codes to iso-693-3 codes.

nvkelso commented 8 years ago

This is pretty awesome :)

screen shot 2016-08-09 at 23 13 23 screen shot 2016-08-09 at 23 13 37

/cc @thisisaaronland