tilfinltd / aws-extend-switch-roles

Extend your AWS IAM switching roles by Chrome extension, Firefox add-on, or Edge add-on

https://chromewebstore.google.com/detail/aws-extend-switch-roles/jpmkfafbacpgapdghgdpembnojdlgkdl?utm_source=github

MIT License

1.33k stars 140 forks source link

Fix #111 #112

Closed timcleaver closed 4 years ago

timcleaver commented 5 years ago

Replace the role color label in the original role history with images if the profiles have one.

codecov[bot] commented 5 years ago

Codecov Report

Merging #112 into master will decrease coverage by 3.67%. The diff coverage is 75%.

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   89.06%   85.39%   -3.68%     
==========================================
  Files           9        9              
  Lines         311      315       +4     
==========================================
- Hits          277      269       -8     
- Misses         34       46      +12

Impacted Files	Coverage Δ
src/lib/content.js	`91.15% <75%> (-5.35%)`	:arrow_down:
src/lib/auto_assume_last_role.js	`84% <0%> (-16%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bb7fab5...fed8017. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #112 into master will decrease coverage by 0.74%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   88.11%   87.37%   -0.75%     
==========================================
  Files           9        9              
  Lines         303      309       +6     
==========================================
+ Hits          267      270       +3     
- Misses         36       39       +3

Impacted Files	Coverage Δ
src/lib/content.js	`93.19% <50.00%> (-1.84%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a1e4c8b...667989c. Read the comment docs.

tilfin commented 5 years ago

@timcleaver Thanks! But please rebase your master from my master and squash the changes into 1 commit.

timcleaver commented 5 years ago

I have tried to rebase. It isn't something I have had to do with git previously (I intentionally keep my usage simple). Hopefully the commit log looks correct?

tilfin commented 4 years ago

With the latest version of the specification, this issue is no longer relevant.