tilfinltd / aws-extend-switch-roles

Extend your AWS IAM switching roles by Chrome extension, Firefox add-on, or Edge add-on
https://chromewebstore.google.com/detail/aws-extend-switch-roles/jpmkfafbacpgapdghgdpembnojdlgkdl?utm_source=github
MIT License
1.32k stars 141 forks source link

Plugin Broken Following AWS Console UI Update #156

Closed jtstrohl closed 3 years ago

jtstrohl commented 4 years ago

This AWS Extend Switch Roles plugin, my most beloved Chrome plugin of all time, appears to be broken after an update was released to the AWS Console -- literally minutes ago. All of the sudden, the username dropdown menu (top right) only displays the last 5 roles in my history and no longer displays my entire list of account/roles configured for the plugin, even though I have configured it to hide original role history.

I hope this is a simple fix!

jtstrohl commented 4 years ago

Must have been a fluke.... After logging back into AWS, it's fixed.

jtstrohl commented 4 years ago

OK, it's broken again..... I think they are releasing the UI update in a weighted-DNS distribution deployment, so sometimes it's the old and sometimes it's the new.

jtstrohl commented 4 years ago

I discovered that the AWS Console UI update is only being rolled out to certain AWS accounts. The extension works in accounts where it hasn't been rolled out, but is broken in those where it has.

michal-adamkiewicz commented 4 years ago

confirm, broken on my side also 😢 😢 😢

tobiasadam0770 commented 4 years ago

Same here…

kickasstimus commented 4 years ago

same here -- works in accounts using the old UI, but not the new -- same behavior as reported above.

kickasstimus commented 4 years ago

Part of the problem is that this id: awsc-login-account-section no longer exists, and so this:

var parentEl = elById('awsc-login-account-section'); parentEl.appendChild(divLbl); parentEl.appendChild(ul);

... this breaks. I'm sure there are other problems related to re-named id's. It seems like a great deal of the page language has changed.

mtamassia commented 4 years ago

Same issue / problem. Since AWS pushed their new experience (started yesterday) this add-on no longer works.

kareemdarkazanli commented 4 years ago

Hi I’m with the AWS Console team and we’d like to help make it easier for this third-party extension to onboard with new navigation. We’ve sent an email to the author but if there’s a different method of contact or PoC please let me know. Thanks

jlongman commented 3 years ago

@kareemdarkazanli is there a secret or is it something you can share? At a certain point, anyone here can create a pull request to help the author get this done.

tilfin commented 3 years ago

Firstly, now applying new navigation UI to my AWS Account by them.

camlog commented 3 years ago

@kareemdarkazanli How long is the dashboard A/B testing going to continue? Making a patch for this will be trickier whilst there are 2 versions of the dashboard in play.

kickasstimus commented 3 years ago

Can I raise a support call on AWS to put my account back to the old console until this plugin is updated?

I tried, but AWS isn't doing it. Since this is a 3rd party tool, and one that scrapes the UI to function, they don't have any obligation or desire to cater to it so the changes were not rolled back.

kickasstimus commented 3 years ago

Once again, relevant xkcd: https://xkcd.com/2347/

x3dfxjunkie commented 3 years ago

Just to add to this, when I first log in to AWS, it seems broken. If I manually switch roles, the add-on then starts to work.

jjhatobjective commented 3 years ago

Is there a way to opt out of the new UI for accounts ? Our org uses this plugin pretty heavily and the few accounts that got the new UI are currently in chaos.

jon-flowers commented 3 years ago

As mentioned above, it does appear that this is a full canary / A/B testing process that we are in the middle of. I am seeing random changes to the new UI depending on different roles / regions / accounts, without much consistency yet. The only constant so far is that if I get the old UI, the extension works great. If I get the new UI, it breaks.

jheller commented 3 years ago

@kareemdarkazanli Please, please please AWS give us an opt-out. I REALLY need to be able to use this plugin as I have to deal with a lot of accounts via role switching, and without it I have to waste a lot of time. The standard UI is near useless.

jheller commented 3 years ago

Can I raise a support call on AWS to put my account back to the old console until this plugin is updated?

I tried, but AWS isn't doing it. Since this is a 3rd party tool, and one that scrapes the UI to function, they don't have any obligation or desire to cater to it so the changes were not rolled back.

Then perhaps AWS should address this themselves and make the UI useable without the need for third party plugins. If you work with more than 5 roles, it's frustrating to use. Everyone I know uses this plugin.

tilfin commented 3 years ago

First of all, I saw the phenomenon in my AWS Management Console.

It's not going to be a simple fix due to the impact of the change in style as well as the change in the rendering framework. I have already communicated with the AWS developers via email about this issue.

Thank you for supporting those who have donated.

simonscholey-nasstar commented 3 years ago

Thanks for the update, really appreciate it. Still don't understand why AWS don't have a better native solution...

daknhh commented 3 years ago

After manually assuming a role and reloading the page the plugin is working again.

simonscholey-nasstar commented 3 years ago

@daknhh is that because you are switching into an account that doesn't have the new console applied yet? i have just tried switching and i then get a working extend switch roles but as soon as I switch back to another account with the new UI I lose it again.

daknhh commented 3 years ago

@simonscholeykcom Ah yes you are right.

camlog commented 3 years ago

I've just escalated this through our Technical Account Manager and via a support case too. Sounds like they are keen to either work with @tilfin or to raise a request for feature parity in the Dashboard.

0x91 commented 3 years ago

I've just escalated this through our Technical Account Manager and via a support case too. Sounds like they are keen to either work with @tilfin or to raise a request for feature parity in the Dashboard.

Ditto

tilfin commented 3 years ago

It seems that it is very difficult to apply new stylesheet to the inserted role list items. The reason is that the new UI class name is a random value by the UI framework.

So I have to think of another way and have to reduce some features.

cstavro commented 3 years ago

@tilfin There is likely a better way to do this but if you made a first pass to add your own className to the Role History element (or wherever you need it to be.. at least rooting off there seems pretty stable?), that might negate having to go through and change the rest of the extension as it would just find what it needs to carry on?

Something like:

[...document.querySelectorAll("div")].filter(n => n.childElementCount == 0).filter(n => n.innerText == "Role History")[0].parentElement.className += " cstavro-test"

kormikez commented 3 years ago

So after just 3 days this issue has been upvoted over 80 times already, whereas on Firefox Add-Ons page and Chrome Web Store this priceless plugin has got only 50 reviews altogether (17 for FF, 33 for Chrome). Don't you guys think we owe @tilfin at least some appreciation? ;)

jlongman commented 3 years ago

As a workaround I’ve been putting my cross account role names into my password manager. This is also useful with the AWS Console iOS app.

This is still slicker, as I can colour code and add danger emojis for certain roles and make them visible in the Console.

cstavro commented 3 years ago

@kickasstimus donation information is in the readme. A new donation page run by an unrelated party sounds sketchy to me.

kickasstimus commented 3 years ago

@kickasstimus donation information is in the readme. A new donation page run by an unrelated party sounds sketchy to me.

Good point. Withdrawn. Deleted the original comment and don't forget to donate to tilfin!

kareemdarkazanli commented 3 years ago

Thank you for your patience. We’ve pushed out changes to new navigation that would help support the functionality of this extension (the css still needs some updates). We can support @tilfin if they need to make the css fixes, but the extension should now be functional.

oappicgi commented 3 years ago

first, thanks tilfin for making such a great plugin.

it is bit of a shame that AWS console is somewhat horrible in that regard and hasn't really changed in 4 years I have been working with AWS.

simonscholey-nasstar commented 3 years ago

This looks better. Is the list limit an AWS thing or a ESR plugin thing? I can see the first 28 accounts but can type in the filter box and it limits the list. I can cope with it, just a change of how it works.

timschill commented 3 years ago

Im still having no luck on getting this plugin to work. Could it have anything todo with my config? I have divided it like this:

[master-account-1]
aws_account_id = master-account-1

[profile master1-child1]
role_arn = arn:aws:iam::00000000000:role/My-Role
region = eu-west-1
source_profile = master-account-1
color=ff9300

[profile master1-child2]
role_arn = arn:aws:iam::0000000000:role/My-Role
region = eu-west-1
source_profile = master-account-1
color=ff9300

[master-account-2]
aws_account_id = master-account-2

[profile im-agp]
role_arn = arn:aws:iam::000000000000:role/My-Role
region = eu-north-1
source_profile = master-account-2
color=ff9300
yannickvr commented 3 years ago

Im still having no luck on getting this plugin to work. Could it have anything todo with my config? I have divided it like this:

`

Plugin is still mostly broken currently if you have the new UI. Few days of patience needed probably.

kirnberger1980 commented 3 years ago

Love this plugin and would like to still use it with the new console UI.

goyertp commented 3 years ago

I really appreciate your time developing this plugin. An update would be cool :-)

Thanks / MErci / Danke / Gracias / Obrigado

tilfin commented 3 years ago

@timcleaver @yannickvr The complex configuration does not work in New UI yet after https://github.com/tilfin/aws-extend-switch-roles/issues/156#issuecomment-694621913

https://github.com/tilfin/aws-extend-switch-roles#simple-configuration Please change to the above temporarily and save the original settings somewhere.

simonscholey-nasstar commented 3 years ago

I am using the simple config and it works fine.

tilfin commented 3 years ago

This is a thing I've been thinking about, but it's less affected by showing the role list from the extension browser icon instead of hacking the list in the Console page. So I'm moving it to break through the issue.

paulalex commented 3 years ago

I have noticed this since this morning, when I hit my landing zone account all is well, when I switch roles its broken but also I noticed that all my pinned services in chrome are no longer there, not related to this plugin but just something else I am noting.

trcgravert commented 3 years ago

I have noticed this since this morning, when I hit my landing zone account all is well, when I switch roles its broken but also I noticed that all my pinned services in chrome are no longer there, not related to this plugin but just something else I am noting.

I fear that's by AWS design. The pins are now your favorites in the dropdown menu. I'm not too fond of these changes.

jtstrohl commented 3 years ago

I'm a huge fan of AWS, but I'm not too fond of a lot of the changes in these "New UI Experiences" being released lately. Most people don't like changes to their UI unless there are significant usability benefits.... If it ain't broke, don't fix it!

On Fri, Sep 18, 2020, 6:52 AM trcgravert notifications@github.com wrote:

I have noticed this since this morning, when I hit my landing zone account all is well, when I switch roles its broken but also I noticed that all my pinned services in chrome are no longer there, not related to this plugin but just something else I am noting.

I fear that's by AWS design. The pins are now your favorites in the dropdown menu. I'm not too fond of these changes.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/tilfin/aws-extend-switch-roles/issues/156#issuecomment-694823881, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIP4QT2DH3LOMKUJPCZ5HLSGNCXVANCNFSM4RML72HA .

paulalex commented 3 years ago

I fear that's by AWS design. The pins are now your favorites in the dropdown menu. I'm not too fond of these changes.

Indeed they are, thank you for pointing that out, I prefer them where they were if I am honest as now I need to click the "Services" link to get to the favourites, the entire reason I pinned them in the first place!

jtstrohl commented 3 years ago

Exactly what I don't like about the new UIs... Less efficient use of screen real estate, more clicks and scrolling required than before, especially for repetitive tasks. Information is more separated and hidden and hard to find. I prefer higher information density. The new UIs are pretty, no doubt, but less intuitive and less functional/efficient IMHO. Who moved my cheese?!

On Fri, Sep 18, 2020, 7:16 AM Paul notifications@github.com wrote:

I fear that's by AWS design. The pins are now your favorites in the dropdown menu. I'm not too fond of these changes.

Indeed they are, thank you for pointing that out, I prefer them where they were if I am honest as now I need to click the "Services" link to get to the favourites, the entire reason I pinned them in the first place!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/tilfin/aws-extend-switch-roles/issues/156#issuecomment-694833399, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIP4QWIRK2AFL334EZ42N3SGNFQ3ANCNFSM4RML72HA .

tilfin commented 3 years ago

I pre-released AESR V2, you can get zip files of it in https://github.com/tilfin/aws-extend-switch-roles/pull/157#issuecomment-694912913

daveofthedogs commented 3 years ago

I have noticed this since this morning, when I hit my landing zone account all is well, when I switch roles its broken but also I noticed that all my pinned services in chrome are no longer there, not related to this plugin but just something else I am noting.

I fear that's by AWS design. The pins are now your favorites in the dropdown menu. I'm not too fond of these changes.

Is ANYBODY fond of the UI changes? They have all been crap.

Yuxael commented 3 years ago

I pre-released AESR V2, you can get zip files of it in #157 (comment)

I don't recall when was the last time I was so happy about any pre-release/update. You sir, just saved our lives from eternal torment of crappy UI.