tilfinltd / aws-extend-switch-roles

Extend your AWS IAM switching roles by Chrome extension, Firefox add-on, or Edge add-on
https://chromewebstore.google.com/detail/aws-extend-switch-roles/jpmkfafbacpgapdghgdpembnojdlgkdl?utm_source=github
MIT License
1.32k stars 141 forks source link

fix: temporary fix before V2 is released #158

Closed kennith closed 3 years ago

kennith commented 3 years ago

this is a temporary fix before V2 releases.

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@bd9fb81). Click here to learn what that means. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #158   +/-   ##
=========================================
  Coverage          ?   88.34%           
=========================================
  Files             ?        9           
  Lines             ?      309           
  Branches          ?        0           
=========================================
  Hits              ?      273           
  Misses            ?       36           
  Partials          ?        0           
Impacted Files Coverage Δ
src/lib/content.js 95.23% <100.00%> (ø)
src/lib/data_profiles_splitter.js 100.00% <0.00%> (ø)
src/lib/profile_set.js 100.00% <0.00%> (ø)
src/lib/load_aws_config.js 100.00% <0.00%> (ø)
src/lib/auto_assume_last_role.js 100.00% <0.00%> (ø)
src/lib/common.js 93.33% <0.00%> (ø)
src/sanitizer.js 58.82% <0.00%> (ø)
src/lib/lz-string.min.js 100.00% <0.00%> (ø)
src/lib/color_picker.js 4.54% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bd9fb81...25545c8. Read the comment docs.

shahbour commented 3 years ago

how can we update to this ?

bateller commented 3 years ago

I attempted the changes to src/lib/content.js then ran bin/build.sh and the newly created dist/chrome didn't appear to work for me with the new AWS console design

kennith commented 3 years ago

@bateller I think there are two things to check.

  1. did you copy the configurations into the extension that you manually loaded?
  2. if you don't see the role list and search box, can you manually do a role switch once?

these were the two things I needed to do when I run the extension for the first time.