feat: added darkmode - Githubissues

tilfinltd / aws-extend-switch-roles

Extend your AWS IAM switching roles by Chrome extension, Firefox add-on, or Edge add-on

https://chromewebstore.google.com/detail/aws-extend-switch-roles/jpmkfafbacpgapdghgdpembnojdlgkdl?utm_source=github

MIT License

1.32k stars 141 forks source link

feat: added darkmode #288

Closed XargsUK closed 1 year ago

XargsUK commented 1 year ago

options.html / popup.html

inline css updated to contain .dark-mode classes
added darkModeCheckBox to options.html

options.js

added check in options.js if dark-mode enabled, then add dark-mode class.
added darkMode to booleanSettings const

popup.js

added check in options.js if dark-mode enabled, then add dark-mode class.

Resolves: #210

XargsUK commented 1 year ago

Added the CSS to the HTML inline as to avoid changing the application to much to get this merged. However, I do recommend moving the inline CSS to a separate CSS file and bundling it as part of the build process. This will help with maintainability and make it easier to update the styling across multiple pages.

XargsUK commented 1 year ago

Closing off. Will reopen rebased off feature/manifest-v3