Implemented tilfinltd/aws-extend-switch-roles#290

tilfinltd / aws-extend-switch-roles

Extend your AWS IAM switching roles by Chrome extension, Firefox add-on, or Edge add-on

https://goo.gl/0QFjow

MIT License

1.31k stars 140 forks source link

Implemented tilfinltd/aws-extend-switch-roles#290 #295

Closed XargsUK closed 4 months ago

XargsUK commented 1 year ago

Added checkbox option enableImageBorderColor to options.js and options.html

When enabled, if image and color are both passed to the createRoleListItem function, then a 3px border is shown around the image.

This required me to pass enableImageBorderColor value when createRoleListItem() is called in popup.js renderRoleList

closes #290

XargsUK commented 1 year ago

This PR should serve as an example to any readers as to why you shouldn't do a PR at 2:30am... I am so sorry for the history on this one @tilfin! First time working with playwright