Order of AWS accounts in role list should be controllable.

tilfinltd / aws-extend-switch-roles

Extend your AWS IAM switching roles by Chrome extension, Firefox add-on, or Edge add-on

https://goo.gl/0QFjow

MIT License

1.31k stars 140 forks source link

Order of AWS accounts in role list should be controllable. #313

Closed quantumdecoherence closed 8 months ago

quantumdecoherence commented 8 months ago

Describe the bug The latest update broke the ordering of AWS accounts in the role list. When clicking the switcher button, the order used to be determined by the order of accounts in the configuration. This made it easy to have the few most used accounts on top of the list. With the update, the order is mixed up in a way that is unclear to me. The most used accounts are at the bottom of the list, which for my org, is quite long.

To Reproduce Steps to reproduce the behavior:

Click on 'AWS Extend Switch Roles Button in Firefox Toolbar'
See error

Expected behavior Roles in order of definition in the config, or at least a way to reorder the list.

Environment

OS: Ubuntu 22.04 LTS with all current updates
Firefox 118.0.2 (not snap-Version from repositories)
AWS Extend Switch Roles v4.0.0

tilfin commented 8 months ago

@quantumdecoherence It is expected that listings will be made in the order of definition in the Configuration.

Would it be the same if I try it in Chrome?
Which way of writing do you define the profile, Simple Configuration or Complex Configuration (which specifies source_profile)?

quantumdecoherence commented 8 months ago

@tilfin

yes, it's the same for Chrome (v118, also)
mixed. The few important profiles are Simple Configuration, the rest is Complex with a source_profile. Which makes me realize that the Simple profiles are now sorted to the end of the list, despite being at the top of the configuration. The order within the Simple and Complex sub-lists seems to be retained.

Since I don't know how to color the profiles in Complex Config, I guess one workaround would be to only use Simple Config, which I've not done since the AWS configuration file maps to complex without any work, and most accounts don't need colors.

tilfin commented 8 months ago

@quantumdecoherence Thank you. I have confirmed that the concatenation order of the profiles in the single configuration and the profiles in the complex configuration has been reversed.

The color and image parameters can also be defined in Complex Configuration.

[child-profile]
aws_acount_id = 000011112222
role_name = Admin
source_profile = parent-profile
color = ff3300
image = https://example.com/icon.png