Can't PR this repo - SRCDSLAB Fork

tilgep / stripper

Sourcepawn implementation of Stripper:Source

20 stars 8 forks source link

Can't PR this repo - SRCDSLAB Fork #6

Open Rushaway opened 1 month ago

Rushaway commented 1 month ago

I tried to PR srcdslab repo to your repo, but I got an error. Pull request creation failed. Validation failed: must be a collaborator

Anyway let's find the changelog:

Github CI (Dependabot and autobuild plugin smx with the release when a commit is made)
Use conventionnal SM architecture
Add forwards and natives for API (to send infos to discord for example)
Improve plugin speed performance (benchmarks was made)
Improve lowecase name logic

I hope you will consider it to merge this.

tilgep commented 1 month ago

I'm not sure why a native is needed to log stripper errors, but the rest seems fine.

Rushaway commented 1 month ago

Native can be used to have an easier trace to find logs, rather than the LogError. So you can logs all errors related to a maps into an individual file. This leaves everyone free to do what they want. Example:

Rushaway commented 3 weeks ago

Are you ok with this ?