search

tiliado / nuvola-app-amazon-cloud-player

Amazon Cloud Player script for Nuvola Apps Runtime.
https://nuvola.tiliado.eu/app/amazon_cloud_player/
BSD 2-Clause "Simplified" License
7 stars 7 forks source link

Amazon Cloud Player script #2

Closed SteVwonder closed 9 years ago

SteVwonder commented 9 years ago

Sorry this took so long. I integrated all of the suggested changes from #1, except the national variants.

Once this PR is merged, either you or I should open an issue about the variants. I can probably look into it this weekend.

jiri-janousek commented 9 years ago

Thanks, @SteVwonder. I've added this code review to the roadmap for July 2015 tiliado/nuvolaplayer.project#3

jiri-janousek commented 9 years ago

Hello. I'm ready to merge you branch as soon as you fix one minor issue (see inline comment). However, I won't create packages until the national variants are supported. Will you take a look at it or should I take care of it?

SteVwonder commented 9 years ago

I commented out the console logs. I don't have time the next two weeks to look into the variants, but I can the first week of August.

jiri-janousek commented 9 years ago

Great :+1: I will merge this PR later today. You can then create a new PR for national variants when it's ready.