Release 5.5 - Githubissues

tiliado / nuvola-app-amazon-cloud-player

Amazon Cloud Player script for Nuvola Apps Runtime.

https://nuvola.tiliado.eu/app/amazon_cloud_player/

BSD 2-Clause "Simplified" License

7 stars 7 forks source link

Release 5.5 #27

Closed a-m-s closed 6 years ago

a-m-s commented 7 years ago

The plugin now supports the new seek API.

jiri-janousek commented 7 years ago

Thanks @a-m-s.

Is there any reason why you parse track length/position in two different ways? Once with Nuvola.parseTimeUsec and then with your custom parsing.
Is it feasible to integrate volume management as well?

a-m-s commented 7 years ago

I wrote the custom one before I found parseTimeUsec, and then there wasn't any great need to change it.

I'll take a look at volume management.

a-m-s commented 7 years ago

When the volume slider is closed it's only possible to detect three volume levels ("mute", "min", and "mid"), and it can't be changed. I can probably simulate a click to flick open the volume control and set volume, but that seems a little unsatisfactory for reading. Maybe once at the start, for a moment, and then whenever the user has it open.

Volume will be less straight-forward than track position, but just about doable.

jiri-janousek commented 7 years ago

Maybe once at the start, for a moment, and then whenever the user has it open.

That should be good enough. In Deezer, the volume bar is hidden with CSS but the current volume is still accessible via DOM. However, I need to apply a few CSS styles to show the volume bar to change volume.

a-m-s commented 7 years ago

I believe volume controls should be working now.

It turned out to be more challenging that I'd expected because clickOnElement was not sufficient. It turns out the mouseenter event enables volume changes, and the mouseout event makes the change permanent.

a-m-s commented 7 years ago

And the custom time parsing is gone too, so that should be all your objections addressed.

jiri-janousek commented 7 years ago

And the custom time parsing is gone too

[x] See my comment on ad2e5fbd2c0ae0cbf28c65b9164c13bf2c362ce5

that should be all your objections addressed.

Well, Nuvola 4.6 is out with new features, so there is still some work to do ;-)

[x] Since Nuvola 4.6 supports MSE, could you check whether Amazon Cloud Player works with "requirements": "Codec[MP3] Feature[MSE]". If not, use "requirements": "Codec[MP3] Feature[Flash]" as Flash won't be enabled by default once all scripts are updated to specify their requirements.
[ ] Does Amazon contain any rating system like thumb up/down, like/dislike or star rating? If yes, could you look at track rating feature? This can wait for release 5.6 though if you wish so.

a-m-s commented 7 years ago

Amazon does have thumbs. I already started looking at it. Nothing implemented yet.

jiri-janousek commented 6 years ago

Hello @a-m-s. This ticket has stalled a bit. Do you want me to release 5.5 at the current state and postpone the last two points from my previous comment to the 5.6 release?

a-m-s commented 6 years ago

Sorry, I've not had time to look at it for a while. The thumbs feature need not hold up a release.

How important is the MSE vs. Flash thing?

a-m-s commented 6 years ago

I don't have time to get to the thumbs, but I did manage to test the feature flags. Apparently the player uses Flash to play any music which is not "owned" by the user.

a-m-s commented 6 years ago

BTW, I didn't add a changelog entry as the change is not user-visible.

jiri-janousek commented 6 years ago

I don't have time to get to the thumbs

No problem, reticketed as #29.

jiri-janousek commented 6 years ago

Will rebuild the flatpak package with the upcoming Nuvola 4.8.

jiri-janousek commented 6 years ago

Draft: https://medium.com/nuvola-news/nuvola-4-8-adds-pocket-casts-fixes-groove-music-temporarily-drops-spotify-and-calls-for-new-6ff7cfacac97