search

tiliado / nuvola-app-amazon-cloud-player

Amazon Cloud Player script for Nuvola Apps Runtime.
https://nuvola.tiliado.eu/app/amazon_cloud_player/
BSD 2-Clause "Simplified" License
7 stars 7 forks source link

Integrate thumb up/down or like/dislike #29

Closed jiri-janousek closed 6 years ago

jiri-janousek commented 7 years ago

Reticketed from https://github.com/tiliado/nuvola-app-amazon-cloud-player/issues/27#issuecomment-320443118

Does Amazon contain any rating system like thumb up/down, like/dislike or star rating? If yes, could you look at track rating feature? This can wait for release 5.6 though if you wish so.

jiri-janousek commented 6 years ago

Hello, @a-m-s. Would it be possible to include this in the next release? Do you need some assistance?

a-m-s commented 6 years ago

Sorry, it just got forgotten.

a-m-s commented 6 years ago

This is now implemented, but there's no default key binding defined, which probably isn't helpful. Otherwise, the Amazon app seems to treat thumb up as a toggle button, and thumb down as a simple action, which may be confusing for the UI.

Do you have any precedence for thumb bindings?

a-m-s commented 6 years ago

No reply, so I'm just going to call this done.

jiri-janousek commented 6 years ago

Sorry, I've forgotten to finish and send my reply. I don't have any preference for the thumbs keybinding, users can set whatever they wish. Regarding that thumbs down behavior: Google Play Music sets the thumbs-down state and then skips to the next song. If you play the playlist again and get to the thumb-down song, you can press thumbs down to remove the thumbs-down state. What does Amazon do?

a-m-s commented 6 years ago

The interface shows both thumb up and thumb down buttons, which suggests there could be three states: up, down, neither.

Actually clicking the button suggests that there are really only two states: up, or not. The thumbs down button seems to do the same thing as toggling the thumbs up off.

It does not do anything like skipping the track.

jiri-janousek commented 6 years ago

If there are only two states, there is no need for the thumbs down toggle action. You can either remove it or make it a simple action, which should be disabled when the thumbs-up state is toggled off.

a-m-s commented 6 years ago

I think I must be going slightly crazy!? :-(

I just went back to check what it was doing, and indeed it works like you describe google music. You hit thumbs down and it appears not to toggle because it goes straight to the next track.

I know it was late and I was editing this with the sound off, but I don't know how I got confused with this? Maybe I'd screwed up the classes and the site wasn't working right?

Anyway, the current implementation is correct. Both thumb up and down are toggles, and the actions work just fine.

... I'm now wondering how many great tracks I'll never hear again because I've accidentally given them thumb down?

Incidentally the pop-up text suggests that the thumb setting only applies to the current "station", and there are no thumbs at all for "My Music" or playlists (only the fake radio stations).

jiri-janousek commented 6 years ago

Indeed, coding late and without sound is not optimal. I made the same mistake many times :-D