tiliado / nuvolaplayer

Nuvola Player - Tight integration of web-based media streaming services with your desktop
https://nuvola.tiliado.eu/
BSD 2-Clause "Simplified" License
334 stars 27 forks source link

Make scripts pass with Standard JS code style 16.0.1 #674

Closed jiri-janousek closed 3 years ago

jiri-janousek commented 3 years ago

Progress

Procedure

  1. flatpak install nuvola eu.tiliado.NuvolaAdk//master
  2. alias nuvola-adk-master="flatpak run --filesystem=~/projects/nuvola-apps eu.tiliado.NuvolaAdk//master"
  3. nuvola-adk-master
  4. standard --version16.0.1
  5. standard --fix → this should fix most errors
  6. standard → if there are any errors left, you need to fix them manually
  7. Verify changes and push
jiri-janousek commented 3 years ago

Hello @a-m-s, @d-r-q and @Romunix. I've updated the master branch of Nuvola ADK with Standard JS code style checker 16.0.1. Could you look at your scripts and fix new errors? standard --fix should fix most errors. If you need any help, add a comment here. Thanks :-)

jiri-janousek commented 3 years ago

You can also look at fixes applied to my scripts.

ams commented 3 years ago

ams

I think you mean a different person, I have nothing to do with this project.

d-r-q commented 3 years ago

Hi, @fenryxo I will look at it later this week

jiri-janousek commented 3 years ago

ams

I think you mean a different person, I have nothing to do with this project.

Yes, you're right. @a-m-s is the correct person. Sorry for the noise.

jiri-janousek commented 3 years ago

Hello, @a-m-s, any chance you could manage to port your scripts before 2020-11-28? :-)

jiri-janousek commented 3 years ago

Hello, @a-m-s, any chance you could manage to port your scripts before 2020-12-27? :-)

jiri-janousek commented 3 years ago

All green.