search

tiliado / nuvolasdk

Nuvola Apps SDK - SDK for building Nuvola web app scripts for Nuvola Apps Runtime.
https://pypi.python.org/pypi/nuvolasdk
BSD 2-Clause "Simplified" License
3 stars 3 forks source link

rpmlint reports W: dangling-relative-symlink #3

Closed jiri-janousek closed 7 years ago

jiri-janousek commented 7 years ago

@martinkg commented on Mon Jun 19 2017

Rpmlint
-------
Checking: nuvola-app-amazon-cloud-player-5.4-3.fc27.noarch.rpm
          nuvola-app-amazon-cloud-player-5.4-3.fc27.src.rpm
nuvola-app-amazon-cloud-player.noarch: W: spelling-error %description -l en_US linux -> Linux
nuvola-app-amazon-cloud-player.noarch: W: dangling-relative-symlink /usr/share/icons/hicolor/24x24/apps/nuvolaplayer3_amazon_cloud_player.png ../../../../nuvolaplayer3/web_apps/amazon_cloud_player/icons/24.png
nuvola-app-amazon-cloud-player.noarch: W: dangling-relative-symlink /usr/share/icons/hicolor/22x22/apps/nuvolaplayer3_amazon_cloud_player.png ../../../../nuvolaplayer3/web_apps/amazon_cloud_player/icons/22.png
nuvola-app-amazon-cloud-player.noarch: W: dangling-relative-symlink /usr/share/icons/hicolor/48x48/apps/nuvolaplayer3_amazon_cloud_player.png ../../../../nuvolaplayer3/web_apps/amazon_cloud_player/icons/48.png
nuvola-app-amazon-cloud-player.noarch: W: dangling-relative-symlink /usr/share/icons/hicolor/64x64/apps/nuvolaplayer3_amazon_cloud_player.png ../../../../nuvolaplayer3/web_apps/amazon_cloud_player/icons/64.png
nuvola-app-amazon-cloud-player.noarch: W: dangling-relative-symlink /usr/share/icons/hicolor/128x128/apps/nuvolaplayer3_amazon_cloud_player.png ../../../../nuvolaplayer3/web_apps/amazon_cloud_player/icons/128.png
nuvola-app-amazon-cloud-player.noarch: W: dangling-relative-symlink /usr/share/icons/hicolor/scalable/apps/nuvolaplayer3_amazon_cloud_player.svg ../../../../nuvolaplayer3/web_apps/amazon_cloud_player/icons/scalable.svg
nuvola-app-amazon-cloud-player.noarch: W: dangling-relative-symlink /usr/share/icons/hicolor/16x16/apps/nuvolaplayer3_amazon_cloud_player.png ../../../../nuvolaplayer3/web_apps/amazon_cloud_player/icons/16.png
nuvola-app-amazon-cloud-player.noarch: W: dangling-relative-symlink /usr/share/icons/hicolor/256x256/apps/nuvolaplayer3_amazon_cloud_player.png ../../../../nuvolaplayer3/web_apps/amazon_cloud_player/icons/256.png
nuvola-app-amazon-cloud-player.noarch: W: dangling-relative-symlink /usr/share/icons/hicolor/32x32/apps/nuvolaplayer3_amazon_cloud_player.png ../../../../nuvolaplayer3/web_apps/amazon_cloud_player/icons/32.png
nuvola-app-amazon-cloud-player.noarch: W: desktopfile-without-binary /usr/share/applications/eu.tiliado.NuvolaAppAmazonCloudPlayer.desktop nuvola
nuvola-app-amazon-cloud-player.src: W: spelling-error %description -l en_US linux -> Linux
nuvola-app-amazon-cloud-player.src:29: W: configure-without-libdir-spec
2 packages and 0 specfiles checked; 0 errors, 13 warnings.

This is the affected spec file: https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-amazon-cloud-player.spec

@a-m-s commented on Mon Jun 19 2017

@fenryxo This looks like it belongs elsewhere.

@martinkg commented on Mon Jun 19 2017

root@fc25 tmp]# ls -l /usr/share/icons/hicolor/256x256/apps/nuvolaplayer3_amazon_cloud_player.png
lrwxrwxrwx. 1 root root 68  7. Jun 11:48 /usr/share/icons/hicolor/256x256/apps/nuvolaplayer3_amazon_cloud_player.png -> ../../../../nuvolaplayer3/web_apps/amazon_cloud_player/icons/256.png

the link nuvolaplayer3_amazon_cloud_player.png points to file that are not existent.

[root@fc25 tmp]# rpm -ql nuvola-app-amazon-cloud-player |grep nuvolaplayer3
/usr/share/icons/hicolor/128x128/apps/nuvolaplayer3_amazon_cloud_player.png
/usr/share/icons/hicolor/16x16/apps/nuvolaplayer3_amazon_cloud_player.png
/usr/share/icons/hicolor/22x22/apps/nuvolaplayer3_amazon_cloud_player.png
/usr/share/icons/hicolor/24x24/apps/nuvolaplayer3_amazon_cloud_player.png
/usr/share/icons/hicolor/256x256/apps/nuvolaplayer3_amazon_cloud_player.png
/usr/share/icons/hicolor/32x32/apps/nuvolaplayer3_amazon_cloud_player.png
/usr/share/icons/hicolor/48x48/apps/nuvolaplayer3_amazon_cloud_player.png
/usr/share/icons/hicolor/64x64/apps/nuvolaplayer3_amazon_cloud_player.png
/usr/share/icons/hicolor/scalable/apps/nuvolaplayer3_amazon_cloud_player.svg

@voxik commented on Wed Jun 21 2017

I think this could be outfall of the nuvolaplayer -> nuvolaruntime rename.

@martinkg commented on Wed Jun 21 2017

@voxik

is it ok if i place the sed command in the %build section ?

%build
./configure --prefix=%{_prefix}
sed -i -e 's|nuvolaplayer3|nuvolaruntime|' Makefile
%make_build
jiri-janousek commented 7 years ago

They should point to nuvolaruntime/web_apps/...

jiri-janousek commented 7 years ago

Fix released in 4.5.0.