Sky Dolly 0.17.x does not record anymore

[till213]

Describe the bug When trying to record a flight the record button gets activated ("red"), a (temporary) new logbook entry is made (possibly also indicating the actual aircraft type), but the recording does not proceed:

• The timer remains at 00:00:00
• The time slider remains at its leftmost position (instead of the rightmost position)
• When stopping the recording the flight is not persisted (the temporary logbook entry disappears again)

To Reproduce Steps to reproduce the behavior:

1. Launch MSFS and Sky Solly
2. Start a flight in MSFS
3. Press "Record" (key R), wait for a while
4. Stop "Record" (key R again, or key S)
5. BUG: the newly created logbook entry disappears again (not persisted: no recorded data)

Expected behavior The simulation variables - specifically position data - should be recorded and persisted.

Screenshots If applicable, add screenshots to help explain your problem.

Application version:

• v0.17.1

Note: it still works with the v0.17.0. So this is a regression introduced with v0.17.1.

Additional context

[till213]

This is the culprit:

https://github.com/till213/SkyDolly/compare/v0.17.0...v0.17.1 src/Plugins/Connect/MSFSSimConnectPlugin/src/MSFSSimConnectSettings.h

enum struct ConnectionType
{
    First = 0,
    Pipe, // BUG: This should be assigned 'First' (value 0) - now it has become value 1, shifting the persisted values by 1
    IPv4,
    IPv6,
    Last = IPv6
};

[till213]

The "ConnectionType" option is indeed "off by 1", in the registry at:

Computer\HKEY_CURRENT_USER\SOFTWARE\till213\Sky Dolly\Plugins\{8ef8d50a-42a1-480a-bee6-b741000e86b4}