till213 / SkyDolly

Sky Dolly connects with Flight Simulator 2020 and records the flight path and basic instruments for replay.
MIT License
77 stars 9 forks source link

Display decimal lat/long #89

Closed scondas closed 1 year ago

scondas commented 1 year ago

Is your feature request related to a problem? Please describe. I deal with decimal lat/long, not hour minutes second.

Describe the solution you'd like Add decimal lat/long to simulation variable display.

till213 commented 1 year ago

"I deal with decimal lat/long, not hour minutes second."

Most people - including me - write coordinates in DMS notation. While I agree that it would be nice to be able to select the preferred unit (including "Imperial vs metric system" etc.) this is very low on my to-do list (if at all) so I am closing this issue, as this won't be implemented anytime soon (there are more useful features ahead).

If you really want to "deal with lat/lon values" then you can export your flight as e.g. GeoJSON or CSV and do all kind of data analysis - with decimal coordinates ;)

scondas commented 1 year ago

While you say "most people" use DMS, I disagree. Here are examples from the aviation world that use decimal: Flightradar24 Web GUI Display, ADS=B web display (https://globe.adsbexchange.com/?icao=aa9b42&lat=32.646&lon=-102.170&zoom=5.5&showTrace=2023-02-04&leg=3&trackLabels), Flightradar CSV format, LittleNavigator gpx format, KML format. Another popular option in aviation is Degrees, minutes and decimal minutes. Anyway, I appreciate your taking the time to have considered this request.

till213 commented 1 year ago

Okay, I do take back my "most people" and rephrase it as "I am aware that all display units in Sky Dolly are currently hard-coded to some random choice, either heavily influenced by the default units of MSFS itself (knots, feet, ...) or simply as decided by me" ;)

And yes, I totally agree that it would be nice to have user-defined units, be able to quickly switch between imperial and metric units (and at the end of all that would be proper "internationalisation" - but at least the decimal numbers do take your "user locale" into account already).

All I am saying here that there are plenty of other features that I'd like to implement first, and that "cosmetic issues" such as "DMS vs feet" are currently outside of my "time budget". Hence I'd rather close this issue for now, to let you know that it is unlikely that this gets implemented by me anytime soon.

On the other hand I keep my liberty to change my mind anytime about this :) But for now it's going to be DMS, as this is also the unit in which coordinates are displayed in MSFS - so at least I am consistent with MSFS.

So should I ever reach the point where I say "Huh! What else could I implement now in Sky Dolly? Ah, selectable units - and translations :)" then I certainly keep this DMS vs decimal notation in my mind!

P.S. And just as a side-note: while the "Location" module (consistently) also shows the coordinates in DMS (for the reader: degrees, minutes, seconds) notation you can copy & paste pretty much all "coordinate flavours" into the table (yes, including decimal notation, as copy & pasted from Bing Maps etc.).

till213 commented 1 year ago

Flightradar CSV format,

Oh, and just for the record: "raw data formats" do not count in my book ;) After all, I could also argue that Sky Dolly stores its value in decimal format in the database (of course) and exports them as decimal in its various export formats. ;)

scondas commented 1 year ago

I agree with your comments on raw data format, and withdraw those examples, I stand by the others. Again, I really appreciate your time to have considered this request, and I will address it in my private version of the software.

till213 commented 1 year ago

I will address it in my private version of the software.

That would be in the "Aircraft Widget":

https://github.com/till213/SkyDolly/blob/65074a5b691856ea86cd7960a7d5512d5703f7c5/src/UserInterface/src/Widget/AircraftWidget.cpp#L78

But somehow I have the feeling that you figured that one out already ;)

till213 commented 1 year ago

Nah, what the heck...

grafik

Consider it done ;)

scondas commented 1 year ago

That's fantastic! Makes it so much easier to compare the Sky Dolly flight to the original inputs. Thanks!