search

tillbaks / node-eiscp

node module to interface with onkyo receivers (eiscp protocol)
MIT License
30 stars 49 forks source link

Can't go above volume level 80, even though the on screen GUI says otherwise #1

Closed robbiet480 closed 10 years ago

robbiet480 commented 10 years ago

I looked at the code but can't figure out where you decide a TX-NR616 is a "set10" model and not "set9". 0-80 works fine. 80-100 throws this:

ERROR (3103) Argument 81 does not exist in command master-volume
TypeError: Cannot read property 'constructor' of undefined
    at _insert (/Users/robbiet480/Repos/automaton/node_modules/eiscp/node_modules/async/lib/async.js:675:18)
    at Object.q.push (/Users/robbiet480/Repos/automaton/node_modules/eiscp/node_modules/async/lib/async.js:705:15)
    at EventEmitter.self.raw (/Users/robbiet480/Repos/automaton/node_modules/eiscp/eiscp.js:380:16)
    at EventEmitter.self.command (/Users/robbiet480/Repos/automaton/node_modules/eiscp/eiscp.js:397:10)
    at app.get.wemoDevices (/Users/robbiet480/Repos/automaton/app.js:103:9)
    at callbacks (/Users/robbiet480/Repos/automaton/node_modules/express/lib/router/index.js:161:37)
    at param (/Users/robbiet480/Repos/automaton/node_modules/express/lib/router/index.js:135:11)
    at param (/Users/robbiet480/Repos/automaton/node_modules/express/lib/router/index.js:132:11)
    at pass (/Users/robbiet480/Repos/automaton/node_modules/express/lib/router/index.js:142:5)
    at Router._dispatch (/Users/robbiet480/Repos/automaton/node_modules/express/lib/router/index.js:170:5)

When I set 80, on screen GUI shows -2dB. I can then manually move up to +18dB, 20 places from -2, via my remote control.

Thanks for the awesome library!

tillbaks commented 10 years ago

Yep, model-sets have not been implemented yet so no model restrictions exist. Looks like range was imported in eiscp-commands.json is 0-80, you could change this in that file for now..

Multiple ranges are not possible as well thats why 0-100 was overwritten by 0-80 when converting from the yaml commands file, need to fix this before implementing model-sets.

I've planned to have model-sets implemeted in the first release version.

robbiet480 commented 10 years ago

Excellent. Thanks for the quick response @tillbaks and thanks again for this, node-itach and node-xbmc. It seems like you and I have similar setups :)