According to ISO C enum values should be within int range. Many values in tk1_mem.h (in tillitis-key1 and in tkey-libs) are outside range. It seems that clang with the flags used in compiling makes this OK, but perhaps we should take action.
One idea is just to use #define instead. And perhaps even just use hardcoded values instead of oring together stuff for ease of porting to other languages?
Note that tk1_mem.h also lives in tkey-libs repo but main location is here.
According to ISO C
enum
values should be withinint
range. Many values intk1_mem.h
(in tillitis-key1 and in tkey-libs) are outside range. It seems that clang with the flags used in compiling makes this OK, but perhaps we should take action.One idea is just to use #define instead. And perhaps even just use hardcoded values instead of oring together stuff for ease of porting to other languages?
Note that
tk1_mem.h
also lives intkey-libs
repo but main location is here.