Open mchack-work opened 2 months ago
The changes would look like this:
// Deprecated - use _ADDR_RAND and _DATA_RAND instead
#define TK1_MMIO_TK1_RAM_ASLR 0xff000100
#define TK1_MMIO_TK1_RAM_SCRAMBLE 0xff000104
#define TK1_MMIO_TK1_RAM_ADDR_RAND 0xff000100
#define TK1_MMIO_TK1_RAM_DATA_RAND 0xff000104
To remove potentially confusing users we might want to change some names.
Quoting @secworks
This potentially changes both Verilog and
tk1_mem.h
.I think it's more important to change the Verilog to avoid using the confusing "ASLR". Such a change doesn't affect software, either, but does affect forks and testbenches.
Changing the header file affects others. We need to be careful here. In the header file we currently have:
If we do a change to the header file, too, we will probably keep the old names for a while, but add the new names, too, just like the old
RAM_ASLR
.