search

tillitis / tillitis-key1

Board designs, FPGA verilog, firmware for TKey, the flexible and open USB security key 🔑
https://www.tillitis.se
382 stars 24 forks source link

Add a make target and script that runs the secret generation. #232

Open dehanj opened 4 weeks ago

dehanj commented 4 weeks ago

The intention is to simplify building a complete bitstream as a user not using the repo everyday. Also added a simple script that can provide some guiding errors if some prerequisite is missing.

A proposal is to extend the script to also include the flashing of nvcm, with instruction along the way.

mchack-work commented 1 week ago

Looks good so far.

Should we have two scripts, one for NVCM and one for flash? Or is the intention to only use the script for NVCM?

dehanj commented 1 week ago

Looks good so far.

Should we have two scripts, one for NVCM and one for flash? Or is the intention to only use the script for NVCM?

Good question. I can think of a few solutions.

  1. Two scripts, one for NVCM and one for flash.
  2. One script, that is interactive. More or less asks for prompts along the way to choose NVCM or flash.

What do your think? Hmm, I believe that 1 is simpler, more explicit and less error prone.

mchack-work commented 1 week ago

I agree. Using two scripts is safer. A user who mistypes can be catastrophic if it's just a question. Unless, maybe, we demand that they type in I AM REALLY HAPPY WITH MY DESIGN in all caps, or something.

But two scripts seems good to me.