Expose qemu_*() functions with QEMU_DEBUG

tillitis / tkey-libs

TKey device libs

GNU General Public License v2.0

4 stars 2 forks source link

Expose qemu_*() functions with QEMU_DEBUG #15

Closed mchack-work closed 9 months ago

mchack-work commented 12 months ago

Instead of hiding the qemu_*() functions with NODEBUG and not even compile them into libcommon, we:

Compile them into their own .o file and link them with libcommon.a always.
Hide them in the qemu_debug.h as void macros when QEMU_DEBUG is not defined. Let the app's compilation define QEMU_DEBUG when it wants to use them and let the linker sort the rest.

See https://github.com/tillitis/dev-tillitis/pull/24 for Dev Handbook changes.

Closes #20

dehanj commented 11 months ago

Did a rebase and fixed a typo.

dehanj commented 11 months ago

Not sure if I'm missing something. If I do not declare -D QEMU_DEBUG in my application i still do get some debug prints in QEMU. These prints comes from tkey-libs and proto.c. Is that intentional?

mchack-work commented 9 months ago

Not intentional. tkey-libs had some of it's own use of the qemu_ functions left. Now just in assert() and ready for merge.

dehanj commented 9 months ago

Looks good now.